add on request 'ci help' command via Gerrit

Description

On 23 February 2017 at 15:10, Martin Sivak <msivak@redhat.com> wrote:
> Hi,
>
> do you think it would make sense to send a copy-and-paste ready
> message with help to every new gerrit change?
>
> It could provide all the system test (lago) links, mention the Rerun
> hooks syntax and so on. Just so we do not have to search for it all
> the time?

This is doable, but I think experienced users may find this annoying
it ifs too long.

I'm thinking it may be better to have such a message just suggesting
to type something like '@ci help' to get the full help.

It may even be possible to make it clickable with some trickery rather
then just copy-and-paster ready (I will need to check if its possible
to inject links into Gerrit comments).

Apart from that, Roy offered to write a Gerrit plugin that will add
buttons with the various CI commands.

Adding infra-support to get a Jira ticket opened.


Barak Korren
bkorren@redhat.com
RHCE, RHCi, RHV-DevOps Team
https://ifireball.wordpress.com/

Activity

Show:

Eyal Edri February 26, 2017 at 5:02 PM

I still think its worth asking the developers again, proposing the relevant options, after all it was their request as you say.
Also, one or two developers might have different ideas then the majority, so we'll need an agreement on one suggestion from the majority.

Barak Korren February 26, 2017 at 4:55 PM

I think top of gerrit or the 1st comment in gerrit are visually equivalent, with the difference that the 1st comment is easier to implement atm...

WRT to developer survey - remember that the suggestion for this came from the developers...

Eyal Edri February 26, 2017 at 4:45 PM

Another option is to add it to the top of the Gerrit as part of the layout.
But anyhow, I think its best to do a short survey on the devel list before implementing this.

Barak Korren February 26, 2017 at 4:35 PM

The thing is - if last week's events taught us anything is that people are not willing to remember anything - not even one command.

I thing that a short enough message, that will appear once and only once when a patch (patch! not patchset!) is created, is unobtrusive enough to not be annoying. The huge benefit of this is that now no one can say he never heard that there is a CI system and it has commands.

This will also be a good place to warn new contributors about not being in the whitelist and tell them what to do.

Eyal Edri February 26, 2017 at 4:19 PM
Edited

I think people will be annoyed by that, it willl spam the comments in all patches.
I think it makes sense to developers to know one command - 'ci please help' e.g., and we need to add it to the signatures of emails from infra to devel, to the Jenkins UI and ovirt site.
So people will only need to remember one command, and once they type it, it will give them info on what is available.

Barak Korren February 26, 2017 at 1:50 PM

Not sure about the change of topic - this is not necessarily "on request" - perhaps we want the CI system to "introduce" itself on each new patch.

Martin Sivak February 23, 2017 at 1:25 PM

> This is doable, but I think experienced users may find this annoying
> it ifs too long.
>
> I'm thinking it may be better to have such a message just suggesting
> to type something like '@ci help' to get the full help.

It does not have to be long, just a summary of all the links once when
the change is posted (so the links can contain the proper change id
and jenkins links).

I am actually more annoyed by the fact that I have to look for the information.

> It may even be possible to make it clickable with some trickery rather
> then just copy-and-paster ready (I will need to check if its possible
> to inject links into Gerrit comments).

That would be even better

> Apart from that, Roy offered to write a Gerrit plugin that will add
> buttons with the various CI commands.

That might work too, but I feel a bot sending a message is faster and
easier to do.

Martin

On Thu, Feb 23, 2017 at 2:18 PM, Barak Korren <bkorren@redhat.com> wrote:
> On 23 February 2017 at 15:10, Martin Sivak <msivak@redhat.com> wrote:
>> Hi,
>>
>> do you think it would make sense to send a copy-and-paste ready
>> message with help to every new gerrit change?
>>
>> It could provide all the system test (lago) links, mention the Rerun
>> hooks syntax and so on. Just so we do not have to search for it all
>> the time?
>
> This is doable, but I think experienced users may find this annoying
> it ifs too long.
>
> I'm thinking it may be better to have such a message just suggesting
> to type something like '@ci help' to get the full help.
>
> It may even be possible to make it clickable with some trickery rather
> then just copy-and-paster ready (I will need to check if its possible
> to inject links into Gerrit comments).
>
> Apart from that, Roy offered to write a Gerrit plugin that will add
> buttons with the various CI commands.
>
> Adding infra-support to get a Jira ticket opened.
>
> –
> Barak Korren
> bkorren@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/

Details

Assignee

Reporter

Components

Priority

Created February 23, 2017 at 1:19 PM
Updated June 24, 2018 at 8:34 AM