Add 'patch owner' feature to Gerrit

Description

Details still TBD, but we want to check if there is a way for the patch author who is the patch 'owner' or 'maintainer' and has the responsibility to make sure the patch is reviewed in time and pushed and not left behind.

It might be Gerrit doesn't support such feature, but we'll check.

please add more info as needed.

Activity

Show:

danken September 18, 2017 at 8:08 PM

seems fine, though the permission to set it are a bit annoying. thanks.

Eyal Edri September 18, 2017 at 12:45 PM

I think the new feature of patch 'assignee' provides exactly the need raised in this ticket, so closing.
please try it and report if there are still missing features which are not answered.

Barak Korren August 31, 2017 at 8:49 AM

New Gerrit now has 'Assignee' field on patches. Please check if this meets your needs.

Former user July 18, 2017 at 1:29 PM

We can configure different flags and values for directories and the reviewers plugin can also be configured to add different people to patches of different files. I do not think it is possible to pass this role though, i.e. if a person can add +2 on a patch, this right can't be transferred to another person for this patch.

danken June 28, 2017 at 10:29 PM

I'd like to look for all the changes of which I'm currently assigned as the chief reviewer. A simple comment is not enough, since it cannot be revoked - if someone asked me to review a change, I should be able to say "actually, the best ReviewAssignee for this is X, not me".

I know that gerrit lets us define flags with numeric values. I wonder if it could also let us define more complex, searchable, key/values.

Barak Korren March 29, 2017 at 10:11 AM

this sounds more like the kind of functionality you would find in a ticketing/task management systems rather then in a code review/scm system. I doubt Gerrit has anything like that built-in.

What would the practical aspects of someone being the ReviewAssignee be? Nag emails? Wouldn't just commenting with "@someone please review this" be enough?

danken March 29, 2017 at 9:07 AM

I'd like to set a single ReviewAssignee to a patch, so that it is very clear to everybody who needs to review this patch today. The current ReviewAssignee can give his score, and pass the role to someone else. In my opinion, anybody can take the role, or grant it to someone else.

This comes to solve the current situation, where a patch has multiple reviewers, but no one in particular is responsible to review this first.

Eyal Edri March 29, 2017 at 9:01 AM

Since you requested this feature, please try to elaborate on the need and use case which this is needed.

Barak Korren March 29, 2017 at 7:09 AM

Gerrit supports a patch owner, author and commiter, all of which can probably be different people (Though I'm not sure what you need to do to configure each field).

What is the real-world use case for this request? Please describe a detailed process.

Fixed

Details

Assignee

Reporter

Blocked By

Priority

Created March 28, 2017 at 2:45 PM
Updated October 1, 2017 at 10:57 AM
Resolved September 18, 2017 at 12:45 PM