Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Re: Findbugs issues not reported correctly on Jenkins master jobs?

Description

Adding infra-support

On Mon, May 15, 2017 at 3:55 PM, Tal Nisan <tnisan@redhat.com> wrote:

> Just a regular "mvn findbugs:findbugs" run on master, you can revert this
> patch and run it manually yourself: https://gerrit.ovirt.org/#/c/76820/
>
> On Mon, May 15, 2017 at 2:15 PM, Daniel Belenky <dbelenky@redhat.com>
> wrote:
>
>> Hi Tal,
>> I'm checking this right now.
>> Can you provide the log from your local run? which files were exported on
>> your local run?
>>
>> On Mon, May 15, 2017 at 11:51 AM Tal Nisan <tnisan@redhat.com> wrote:
>>
>>> I've pushed this patch to master:
>>> https://gerrit.ovirt.org/#/c/75994/
>>> Jenkins showed no findbugs error and I moved on to merging it
>>>
>>> Then I've pushed the same patch to 4.1:
>>> https://gerrit.ovirt.org/#/c/76803/
>>> And it resulted in two findbugs errors (though minor and style related):
>>> http://jenkins.ovirt.org/job/ovirt-engine_4.1_find-bugs_crea
>>> ted/898/findbugsResult/new/
>>>
>>> Running findbugs manually in my environment on master did report these
>>> two issues so I'd expect the master jobs to report them as well.
>>>
>>> _______________________________________________
>>> Infra mailing list
>>> Infra@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>
>> –
>>
>> DANIEL BELENKY
>>
>> RHV DEVOPS
>>
>> Red Hat EMEA <https://www.redhat.com/>
>>
>> IRC: #rhev-integ #rhev-dev
>> <https://red.ht/sig>
>>
>
>
> _______________________________________________
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
>

Activity

Show:

Former user May 23, 2017 at 6:53 AM

This is out of scope for this ticket. I'm moving the ticket to blocked on code-review until we'll merge the fix.
Please let me know if I can assist in any other way.

Tal Nisan May 22, 2017 at 2:26 PM

Quoting amuerini:
"Hi guys,

There's a good chance that patch 07e7e962975fbd1b246d7e82561dfbfb1c6196c9
introduced the regression ans is responsible for the findbugs.xml.xml files.

Can we try reverting it and see what happens?
Thanks."
It's best if we find the cause that this file is generated by this name
instead of adding it as is

On Mon, May 22, 2017 at 5:17 PM, Daniel Belenky (oVirt JIRA) <

Former user May 22, 2017 at 2:17 PM

Ok, so with 's help with sending a faulty patch for debugging, I was able to reproduce the issue and find the root cause.
There is another 'findbugsXml.xml' file that we were not catching in check-patch.sh due to a type.
I'll rebase my patch back to master and resend it to apply the fix.
I'll update here.

Former user May 22, 2017 at 6:51 AM

I can't find any files that are being generated by findbugs that are not being processed by Jenkins.
can you run this check again and paste here the list of files being processed in your local run?

Tal Nisan May 18, 2017 at 11:46 AM

mvn findbugs:findbugs, it generates the report

On Thu, May 18, 2017 at 2:45 PM, Daniel Belenky (oVirt JIRA) <

Fixed

Details

Assignee

Reporter

Blocked By

Priority

Parent

Created May 15, 2017 at 1:07 PM
Updated June 1, 2017 at 11:32 AM
Resolved May 23, 2017 at 1:39 PM

Flag notifications