Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Make change-queue report status to Gerrit

Description

While the basic capabilities for the change-queue to report to Gerrit were already implemented, this had not been enabled yet in order to avoid spamming developers with incorrect messages while the change-queue is still being tested.

Once we are confident that the change queue is working well, we can add reporting to Gerrit.

Attachments

1

Activity

Show:

Anton Marchukov January 30, 2019 at 1:23 PM

is it progressing? If not please move back to Open so it does not show as being "In progress"

Liora Milbaum December 24, 2018 at 12:15 PM

Following discussion with , we should use the following python feature:
"cooperative multiple inheritance pytjhon 2"

Dafna Ron December 13, 2018 at 2:35 PM

any update for me?

Barak Korren October 23, 2018 at 10:53 AM

The `GerritMergedChange` class is used to represet changes that originate from Gerrit in the change queue. That is defined in `scripts/change_queue/changes/_init_.py`.

That class references a `GerritPatchset` object which has a 'review' method that should let you comment on a patch. It basically rings the 'gerrit review' command over the SSH connection to Gerrit. The `GerritPatchset` class is defined in `scripts/gerrit.py`

Dafna Ron October 23, 2018 at 10:46 AM

sorry, I am not sure.
maybe under jenkins/pipelines or under pusher.py?
I think you would be able to give a better answer on this

Details

Assignee

Reporter

Components

Priority

Created June 15, 2017 at 2:26 PM
Updated February 20, 2020 at 12:18 PM