Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

CI +1 marked only on previous patchset

Description

Hi,

In [1], patchset 6 was tested by CI while I pushed an update, 7, which only
changed the commit message. It finished successfully, and only updated 6.
Since 7 is a commit-message-only change, it was never marked or tested.

I guess the code that marked +1 should also check all the newer patchsets
and mark them too if they should inherit.

Thanks,

[1] https://gerrit.ovirt.org/77810
–
Didi

Activity

Show:

Former user September 4, 2017 at 12:08 PM

We have "Exclude No Code Change" set in Jenkins job configs, so it is expected that no builds were triggered.
Existing scores are brought forward to new patchsets with no code change but as noted by there were still no scores when the new patchset was added. Once CI finished it updated the old patchset which is expected.

Barak Korren September 4, 2017 at 10:40 AM

This is an old and known issue. The code doing the marking is not our code and it is built into the Gerrit trigger.

I closing WONTFIX this, please let CI finish before updating commit message.

Won't Fix

Details

Assignee

Reporter

Priority

Created September 4, 2017 at 9:36 AM
Updated October 1, 2017 at 10:57 AM
Resolved September 4, 2017 at 10:40 AM