[Gerrit Hooks] bug-url hook should not verify bugs w/o bug-url: prefix

Description

Gerrit bug check code is treating unrelated urls as Bug-Url:

Patch Set 1: Verified-1

  • Check Bug-Url::1520068::WARN, failed to get bug info (private bug or
    bug doesn't exist)

  • Check Bug-Url::1527827::OK, classification: 'Red Hat', product: 'Red
    Hat Enterprise Virtualization Manager' (-1)

  • Check Product::WARN, failed to get bug info (private bug or bug
    doesn't exist)

  • Check TM::WARN, failed to get bug info (private bug or bug doesn't
    exist)

  • Check Backport::OK, The patch backported to all the relevant stable
    branches.

  • Set POST::#1520068::WARN, failed to get bug info (private bug or bug
    doesn't exist)

  • Update Tracker::#1520068::WARN, failed to get bug info (private bug or
    bug doesn't exist)

  • Update Tracker::#1527827::OK, tracker status: POST

The commit message is:

commit 1b666da534c50321ada448e4bf397cab0306fcf1
Author: Nir Soffer <nsoffer@redhat.com>
Date: Tue Dec 5 23:47:24 2017 +0200

fileSD: Use InterruptibleDirectFile backend

FileStorgeDomainManifest uses now InterruptibleDirectFile for the
external leases backend. This ensure that the process does not become
uninterruptible if storage is non-responsive.

This change bypass the python bug[1] causing the entire process to hang
when opening the special xleases volume. Now the operation is done in
the child process outside of Vdsm.

[1] https://bugzilla.redhat.com/1520068

Change-Id: I8a0eb42baa73b6c0a877ad9acbe53ac51f31bfea
Bug-Url: https://bugzilla.redhat.com/1527827
Signed-off-by: Nir Soffer <nsoffer@redhat.com>

There is exactly one Bur-Url. The other url is a bugzilla url but it should
be consumed only by humans, not by machines. Machines should use
only the Bug-Url.

Nir

Activity

Show:
Eyal Edri
December 21, 2017, 7:56 AM

Not urgent, but might be a good practice to learn on the hooks for anyone in the team.

Eyal Edri
December 21, 2017, 7:55 AM

Thanks for reporting this, it might be a bug in the regex code, so we'll need to look into it.

Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Anton Marchukov

Reporter

Nir Soffer