enable all gerrit hooks for cockpit-ovirt project
Description
Activity
Eyal Edri June 12, 2018 at 6:51 AM
Sorry for the delay on this, it got lost in the hundreds of tickets we have.
I've now enabled it to run ALL hooks:
lrwxrwxrwx. 1 gerrit2 gerrit2 47 Nov 30 2016 change-abandoned.bz.99.update_tracker -> ../update/change-abandoned.bz.99.update_tracker
lrwxrwxrwx. 1 gerrit2 gerrit2 42 Nov 30 2016 change-merged.bz.98.set_modified -> ../update/change-merged.bz.98.set_modified
lrwxrwxrwx. 1 gerrit2 gerrit2 44 Nov 30 2016 change-merged.bz.99.update_tracker -> ../update/change-merged.bz.99.update_tracker
lrwxrwxrwx. 1 gerrit2 gerrit2 46 May 17 05:16 change-restored.bz.99.update_tracker -> ../update/change-restored.bz.99.update_tracker
lrwxrwxrwx. 1 gerrit2 gerrit2 44 Nov 30 2016 patchset-created.bz.1.check_bug_url -> ../check/patchset-created.bz.1.check_bug_url
lrwxrwxrwx. 1 gerrit2 gerrit2 44 Nov 30 2016 patchset-created.bz.2.check_product -> ../check/patchset-created.bz.2.check_product
lrwxrwxrwx. 1 gerrit2 gerrit2 53 Nov 30 2016 patchset-created.bz.3.check_target_milestone -> ../check/patchset-created.bz.3.check_target_milestone
lrwxrwxrwx. 1 gerrit2 gerrit2 45 Jul 5 2017 patchset-created.bz.4.check_backport -> ../check/patchset-created.bz.4.check_backport
lrwxrwxrwx. 1 gerrit2 gerrit2 41 Nov 30 2016 patchset-created.bz.98.set_post -> ../update/patchset-created.bz.98.set_post
lrwxrwxrwx. 1 gerrit2 gerrit2 47 Nov 30 2016 patchset-created.bz.99.update_tracker -> ../update/patchset-created.bz.99.update_tracker
lrwxrwxrwx. 1 gerrit2 gerrit2 52 Mar 8 09:54 update -> /home/gerrit2/review_site/hooks/default-hooks/update
Please let me know if anything else is needed, or open a new ticket for other projects if needed.
Eyal Edri April 8, 2018 at 8:55 AM
@Anton Marchukov any update?
Eyal Edri January 21, 2018 at 7:07 AMEdited
@Anton Marchukov@Dusan Fodor let me know if you need help, the instructions on how to enable more hooks are in the link added to the ticket DESC.
Sandro Bonazzola January 19, 2018 at 2:48 PM
I agree with @Former user , let's enable all of them.
Former user January 17, 2018 at 12:58 PM
I don't see a good reason not to enable all of them.
At a minimum, set_modified would be great
Martin Sivak January 17, 2018 at 12:04 PM
I am not the maintainer, but we have to check all the sla bugs related to cockpit in depth as the status does not reflect the patches.
@Former user should give his opinion here too.
It looks like the cockpit-ovirt project doesn't have all hooks enabled, current these are the hooks its using:
/home/gerrit2/review_site/hooks/custom_hooks/update_tracker
/home/gerrit2/review_site/hooks/custom_hooks/comment-added.propagate_review_values
If we want that the hooks will also update bz status and do other verification like backporing, we need to add more hooks.
@Sandro Bonazzola @Martin Sivak please comment which hooks you'd like to enable or all of them.
Info on the hooks can be found here :http://ovirt-infra-docs.readthedocs.io/en/latest/General/Creating_Gerrit_Projects/index.html#enabling-custom-gerrit-hooks
@Anton Marchukov fyi