Generic webhook plugin changed - need Jenkins command line parameter
Description
Activity
Former user March 12, 2018 at 9:43 AM
Thanks for spotting this issue - I did run a "git grep" to find leftover invocations of the old variable name but by mistake this was done in a subdir so I missed stuff in the piplelines directory. Will avoid pushing anything not reviewed by the CI team to "jenkins" repo in the future.
As for upgrade testing - there's still a lot that needs to be covered by tests, let's discuss it in
Barak Korren March 11, 2018 at 2:06 PM
do you think it's possible to review the changelog of plugins we're upgrading to foresee such changes and make the relevant tests before upgrading the plugins?
Yeah we should probably do that
How can we improve our staging testing to catch such issues?
We probably need to test all the processes end-to-end in the future, like for example create and merge patches to both GitHub and Gerrit staging projects. We already have everything we need setup in the stagin env, but we can consider ways to automate this test in the future.
Eyal Edri March 11, 2018 at 12:18 PM
do you think it's possible to review the changelog of plugins we're upgrading to foresee such changes and make the relevant tests before upgrading the plugins?
How can we improve our staging testing to catch such issues?
Barak Korren March 11, 2018 at 6:56 AM
The changes you`ve made require adjustments in other places in the code as well, please avoid merging any patches to the `jenkins` repo without review in the future.
Former user March 9, 2018 at 2:47 PM
I tested the updated patch using JJB and merged it to prod.
- please confirm that standard-webhook-trigger is now operating propeely so that we can we close this ticket.
Details
Assignee
Former userFormer user(Deactivated)Reporter
Barak KorrenBarak Korren(Deactivated)Priority
Highest
Details
Details
Assignee
Reporter
Priority
Highest
The generic webhook plugin for jenkins seems to have been changed to
increase security.
Previously the plugin was placing all the parameters sent to the
webhook as environment variables, now it only sets explicitly
specified ones.
Unfortunately, our code relied on the previous functionality, so now
all post-merge functionality for GitHub is broken. This is causing,
for example, the ovirt-ansible packages to not get submitted to the
change queues and released.
To restore previous functionality, the following parameter needs to be
passed to jenkins:
-Dhudson.model.ParametersAction.keepUndefinedParameters=true
–
Barak Korren
RHV DevOps team , RHCE, RHCi Evgheny,
Red Hat EMEA
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted