https://lists.ovirt.org breaks HTML links
Description
Activity

Eyal Edri September 2, 2019 at 11:37 AM
are you still working on this?

Marc Dequènes (Duck) March 4, 2019 at 3:44 AM
As see in my fix is creating problems, so I had to revert it and I'm looking for another solution.

Marc Dequènes (Duck) December 28, 2018 at 7:31 AM
Please do not close. I need to follow-up with upstream and get a real fix done somehow.
I also wish to track how I'm going to maintain this workaround in the meanwhile, as for the moment it is manually applied and will vanish on the next code update.

Sandro Bonazzola October 10, 2018 at 5:58 AM
looks like it's working fine, thanks !

Marc Dequènes (Duck) October 10, 2018 at 2:34 AM
Quack,
Upstream (Django) refused to consider the bug; I guess it was too difficult to get this function to work well with HTML content and they gave up. I dug into the problem and produced a patch which is not causing regressions according to the tests, and asked for reconsideration.
In the meanwhile I backported this fix and others related to this function in a special branch. I manually applied the patch on the ML server and it seems all is fine. could you have a look and tell me if you find any problem?
I'm not sure how to maintain this over time. I would not like to put the django package on hold and miss important security fixes. So I guess we'll have to reapply after each upgrade. Maybe I can add this to the playbook.

Marc Dequènes (Duck) October 5, 2018 at 8:18 AM
I did not know Gmail had this behavior.
I found the problem originates in Django and the MM3 developers are aware of it: https://gitlab.com/mailman/hyperkitty/issues/29
I added some more info and opened a BR on Django as the original fix did is not sufficient. I'll dig deeper and see if I can propose a fix. We won't get it in time for CentOS 8 so this means also creating a not too ugly fix. Happily the Hyperkitty code using this function is using a wrapper `urlizetrunc()` in `hyperkitty/templatetags/hk_generic.py` so it should be easy to fix this in a single place.
_o<

Sandro Bonazzola October 5, 2018 at 6:22 AM
I’m not using brackets on purpose, that’s how gmail send the emails with urls

Marc Dequènes (Duck) October 4, 2018 at 1:57 PM
I confirm the problem but that's not something we can change in the settings. Sandro uses angle brackets to wrap URLs and despite the fact that's text/plain it seems to be interpreted or at least the URL boundary is missed. I wonder why it is not using the text/html alternative which is fine (I checked the raw data). So I'm going to look into it but that's probably going to take some time to read the code and find the source of the problem.
As for the "high priority" statement, this does not make me care more, or less, and that's somewhat exaggerated despite being quite annoying. The service works, and noone complained for months, people rarely use brackets around URLs in mails and there's an obvious workaround (resend without the brackets which I believe are not essential to the good reading of this news).

Eyal Edri October 4, 2018 at 11:51 AM
can you check?
Details
Assignee
Marc Dequènes (Duck)Marc Dequènes (Duck)Reporter
Sandro BonazzolaSandro BonazzolaComponents
Priority
Medium
Details
Details
Assignee

Reporter

https://lists.ovirt.org breaks HTML links
Example:
https://lists.ovirt.org/archives/list/users@ovirt.org/thread/U4FW74SLJGWK7ZA2U57JILN674ZKLOMN/
See CEEA-2018:2397 CentOS 7 microcode_ctl Enhancement Update
it points to "
https://lists.centos.org/pipermail/centos-announce/2018-September/023021.html%3E
"
Note the trailing %3E which is ">" and should have not been part of the
link.
Can you please fix it with high priority? It has been reported on twitter
as well.
Thanks,
–
SANDRO BONAZZOLA
MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV
Red Hat EMEA <https://www.redhat.com/>
sbonazzo@redhat.com
<https://red.ht/sig>
<https://www.redhat.com/en/events/red-hat-open-source-day-italia?sc_cid=701f2000000RgRyAAK>