jenkins whitelist issue in ovirt-web-ui
Description
Activity
Barak Korren January 27, 2019 at 9:42 AM
No he does not. He either need to be in the org or added via the bot command.
Adding via the bot command saves the user name in the job XML file, so if we refresh the XML for some reason, like updating the job with JJB, the added user list goes away.
I think we merged a few patches that refreshed all the jobs in the system recently, so that explains why the adding seems to fail from 's point of view.
Since we're making our own Ansible code for the job updates for the containerized masters now, we can consider adding a feature to preserve user whitelists there.
Here are a few other tickets where issues and improvements to the whitelist mechanism have been discussed in the past:
Eyal Edri January 27, 2019 at 8:06 AM
is that true? the user has to be part of the oVirt ORG first before he can be added to whitelist with the 'add to whitelist' or its a bug we need to investigate?
Eyal Edri January 24, 2019 at 8:33 PM
Patches are welcome
but just LMK and I'll update the msg...
Greg Sheremeta January 24, 2019 at 8:07 PM
I asked Bohdan to check.
"I think the user also has to be part of the oVirt org" – that should be in the bot's message, then
Eyal Edri January 24, 2019 at 8:02 PM
I think the user also has to be part of the oVirt org, I've just added 'bond95' user to the oVirt ORG,
can you ask bond95 to send another PR and check it again?
If it doesn't work, ,maybe can check it tomorrow, ( though most people are in devConf).
If not can try to check it next week. I suggest to look at the logs in the webhooks to see what's happening.
Greg Sheremeta January 24, 2019 at 7:49 PM
We've already done this several times. Next time he opens a PR, it will likely happen again.
For example:
https://github.com/oVirt/ovirt-web-ui/pull/904 why didn't that work? Why did he get it again on PR 931?
Eyal Edri January 24, 2019 at 7:43 PM
solving it is just what the bot says to do
a maintainer needs to write "ci add to whitelist" in order to allow the PR to run CI.
I've just done it to the PR and it started running in CI
Details
Details
Assignee
Reporter
Priority
Medium
Please see
https://github.com/oVirt/ovirt-web-ui/pull/931#issuecomment-457248843
"As a security measure, I will not run automated tests on PRs that are not
from white-listed contributors." The bot is lying –
I have 'add to whitelist' for Bohdan several times now.
How do we cure this?
–
GREG SHEREMETA
SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
Red Hat NA
<https://www.redhat.com/>
gshereme@redhat.com IRC: gshereme
<https://red.ht/sig>