upgrade Gerrit to 2.14.20
Description
causes
Activity

Former user October 1, 2019 at 12:06 AM
Upgrade applied to production. Everything works fine yet I see a stack trace in the logs:
[2019-09-30 23:39:49,034] [WorkQueue-1] ERROR com.google.gerrit.server.change.PostReviewers : Cannot send email to new reviewers of change 100666
com.google.gerrit.common.errors.EmailException: Mail Error: Cannot format velocity template NewChange.vm
…
Caused by: org.apache.velocity.exception.MethodInvocationException: Object 'com.google.gerrit.server.mail.send.AddReviewerSender' does not contain method joinStrings(java.util.ArrayList, java.lang.String) at NewChange.vm[line 36, column 14]
…
Notifications are sent properly so I did not roll back the upgrade. The newest build of the reviewers plugin did not change the error.

Former user September 11, 2019 at 2:06 PM
Thanks for the comments. I’ll send an announcement to kubevirt-dev and ovirt devel list, pause CI on both jenkins.ovirt.org and kubevirt-master-stdci-production.apps.ovirt.org/manage and proceed with the upgrade as usual.

Eyal Edri September 11, 2019 at 10:19 AM
so Kubevirt-dev is the only public mailing list I know of that is being used by upstream

Barak Korren September 11, 2019 at 10:17 AM
cnv-devel would only be available to DS developers, while the Jenkins instance is used by the upstream projects

Eyal Edri September 11, 2019 at 10:14 AM
cnv-devel sounds like a good place to announce it
Details
Details
Assignee

Reporter

In order to proceed with we need Gerrit at the latest 4.12 release which is 4.12.20
Since this is a minor release it only includes bug fixes and doesn't change workflows so no major obstacles are expected. I've already upgraded Staging the following way:
wget https://gerrit-releases.storage.googleapis.com/gerrit-2.14.20.war
systemctl stop gerrit
<install latest java if available>
java -jar gerrit-2.14.20.war init -d /home/gerrit2/review_site/
update plugins using the wizard
java -jar /home/gerrit2/review_site/bin/gerrit.war reindex -d /home/gerrit2/review_site/
chown -R gerrit2:gerrit2 /home/gerrit2/review_site
start gerrit or reboot the system to apply updates