Update mock_runner to support the new `--isolation` option for `mock`

Description

Forwarding to infra-support for analysis.

---------- Forwarded message ---------
From: Lev Veyde <lveyde@redhat.com>
Date: Thu, Apr 23, 2020 at 2:02 PM
Subject: Problem with the mock parameters
To: infra <infra@ovirt.org>
Cc: Sandro Bonazzola <sbonazzo@redhat.com>

Hi,

it looks like we have some issues in the mock parameters on some of the
slaves
i.e.:
https://jenkins.ovirt.org/job/ovirt-release_standard-check-patch/387/consoleFull
note the ERROR: Option --old-chroot has been deprecated. Use
--isolation=simple instead.

Thanks in advance,

Lev Veyde

Senior Software Engineer, RHCE | RHCVA | MCITP

Red Hat Israel

<https://www.redhat.com>

lev@redhat.com | lveyde@redhat.com
<https://red.ht/sig>
TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
_______________________________________________
Infra mailing list – infra@ovirt.org
To unsubscribe send an email to infra-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
List Archives:
https://lists.ovirt.org/archives/list/infra@ovirt.org/message/YI577UNFDVGDBXIOKOEEI5G5S2UWXDCA/


Anton Marchukov
Associate Manager - RHV DevOps - Red Hat

Activity

Show:
Barak Korren
April 26, 2020, 2:59 AM

We need to ensure the new `--isolation` option still enables one to use chroots with mock as opposed to systemd-nspawn containers.

If it does support chroot - use can enable it by making `mock_runner.sh` check the output of `mock -h` and use the new option if its found there. We already had code in it that does something like that fromthe last time the mock CLI was changed.

If the chroot support was removed we have two options:

  1. Keep an older version of mock somewhere and use that

  2. Port our code to work with systemd-nspawn. I used to have n epic about this in Jira that detailed what we would need to fix to make that happen. I think most of the more serious fixes are in placealeady anyway.

Lev Veyde
May 12, 2020, 8:21 AM

Just a note, it seems to happen randomly and happened again on ppc64le platform today:

https://jenkins.ovirt.org/job/ovirt-release_standard-check-patch/419/consoleFull

Lev Veyde
May 12, 2020, 5:43 PM
Edited

According to the documentation --isolation=simple is equivalent to --old-chroot and --isolation=nspawn is equivalent to the --new-chroot option.

I updated the patch to rely on the output of the mock -h, and use --isolation if it supports it.

https://gerrit.ovirt.org/#/c/108594/3/mock_configs/mock_runner.sh

Assignee

infra

Reporter

Anton Marchukov

Blocked By

None

Components

Priority

Medium
Configure