Jenkins succeeded, Code-Review +1
Description
Activity
Former user May 6, 2020 at 9:15 AM
All 48 changes that got Code-Review flags from Jenkins have been reviewed and re-triggered when necessary.
I can confirm proper CI votes are being set now by the Jenkins.
Former user May 6, 2020 at 8:16 AM
Indeed, there’s just two changes recorded to the gerrit config (UTC time):
May 5, 2020 3:38:47,357 PM /gerrit-trigger/server/gerrit.ovirt.org/configSubmit by krrai May 6, 2020 7:36:22,225 AM /gerrit-trigger/server/gerrit.ovirt.org/configSubmit by bkorren
Waiting for an update from Krapali on what happened, probably some changes were accidentally changed when reviewing the config for the new instance. We need to be very careful next time to not save any settings unless completely necessary. Will try to locate all jobs that received CR+1 during the period and remove the erroneous flag.
Former user May 6, 2020 at 8:00 AM
Thanks for fixing it Barak, I’m reviewing the cause. did your work on the gerrit integration change anything on the production master?
Barak Korren May 6, 2020 at 7:37 AM
It seems the Gerrit trigger configuration was reset to its default configuration instead of our custom one. I restored it manually. please find out the RC for this.
Former user May 6, 2020 at 7:34 AM
I am looking into it right now
Barak Korren May 6, 2020 at 7:33 AM
Looks liks someone messed up the Gerrit trigger configuration, , , , any idea?
Details
Details
Assignee
Former userReporter
Nir SofferComponents
Priority
High
It is nice to get good review from Jeknins, but I don't think it is smart enough
to do code review, and it should really use Continuous-Integration+1.
Jenkins CI
Patch Set 2: Code-Review+1
Build Successful
https://jenkins.ovirt.org/job/ovirt-imageio_standard-check-patch/2772/ : SUCCESS
See https://gerrit.ovirt.org/c/108772/2#message-6225787b_94ed3eac