+1 for adding the suite name.

BTW, you can run manually OST with your own parameters (engine artifacts
and OST patch set).

Regards,

Shani Leviim

On Thu, Jun 24, 2021 at 3:08 PM Nir Soffer <nsoffer@redhat.com> wrote:

> On Thu, Jun 24, 2021 at 2:11 PM Yedidyah Bar David <didi@redhat.com>
> wrote:
> >
> > On Thu, Jun 24, 2021 at 1:51 PM Marcin Sobczyk <msobczyk@redhat.com>
> wrote:
> > >
> > >
> > >
> > > On 6/23/21 5:44 PM, Nir Soffer wrote:
> > > > Similar to "ci build", "ci test", "ci merge" add a new command that
> > > > triggers OST run.
> > > >
> > > > Running OST is tied now in vdsm (and engine?) to Code-Review: +2.
> > > > This causes trouble and does not allow non-maintainers to use the
> convenient OST
> > > > infrastructure.
> > > >
> > > > Expected flow:
> > > >
> > > > 1. User add a comment with "ci system-test"
> > > "ci system-test" is sooo long, I vote for "ci ost".
> >
> > +1.
> >
> > Perhaps we can add an optional suite name? E.g. 'ci ost
> ansible-suite-master'
>
> +1
> _______________________________________________
> Devel mailing list – devel@ovirt.org
> To unsubscribe send an email to devel-leave@ovirt.org
> Privacy Statement: https://www.ovirt.org/privacy-policy.html
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/SKS3XFCIC6SUPAWV52XMRFQP2CXXLHXG/
>

On Thu, Jun 24, 2021 at 1:49 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
>
>
>
> On 6/23/21 5:44 PM, Nir Soffer wrote:
> > Similar to "ci build", "ci test", "ci merge" add a new command that
> > triggers OST run.
> >
> > Running OST is tied now in vdsm (and engine?) to Code-Review: +2.
> > This causes trouble and does not allow non-maintainers to use the convenient OST
> > infrastructure.
> >
> > Expected flow:
> >
> > 1. User add a comment with "ci system-test"
> "ci system-test" is sooo long, I vote for "ci ost".

Works for me, but "system-test" is more consistent with other ci commands:
https://ovirt-infra-docs.readthedocs.io/en/latest/CI/Using_STDCI_with_Gerrit/index.html#manual-functionality-of-the-ovirt-ci-system

On Thu, Jun 24, 2021 at 2:11 PM Yedidyah Bar David <didi@redhat.com> wrote:
>
> On Thu, Jun 24, 2021 at 1:51 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
> >
> >
> >
> > On 6/23/21 5:44 PM, Nir Soffer wrote:
> > > Similar to "ci build", "ci test", "ci merge" add a new command that
> > > triggers OST run.
> > >
> > > Running OST is tied now in vdsm (and engine?) to Code-Review: +2.
> > > This causes trouble and does not allow non-maintainers to use the convenient OST
> > > infrastructure.
> > >
> > > Expected flow:
> > >
> > > 1. User add a comment with "ci system-test"
> > "ci system-test" is sooo long, I vote for "ci ost".
>
> +1.
>
> Perhaps we can add an optional suite name? E.g. 'ci ost ansible-suite-master'

+1

On Thu, Jun 24, 2021 at 1:51 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
>
>
>
> On 6/23/21 5:44 PM, Nir Soffer wrote:
> > Similar to "ci build", "ci test", "ci merge" add a new command that
> > triggers OST run.
> >
> > Running OST is tied now in vdsm (and engine?) to Code-Review: +2.
> > This causes trouble and does not allow non-maintainers to use the convenient OST
> > infrastructure.
> >
> > Expected flow:
> >
> > 1. User add a comment with "ci system-test"
> "ci system-test" is sooo long, I vote for "ci ost".

+1.

Perhaps we can add an optional suite name? E.g. 'ci ost ansible-suite-master'

Best regards,
–
Didi

On 6/23/21 5:44 PM, Nir Soffer wrote:
> Similar to "ci build", "ci test", "ci merge" add a new command that
> triggers OST run.
>
> Running OST is tied now in vdsm (and engine?) to Code-Review: +2.
> This causes trouble and does not allow non-maintainers to use the convenient OST
> infrastructure.
>
> Expected flow:
>
> 1. User add a comment with "ci system-test"
"ci system-test" is sooo long, I vote for "ci ost".

Regards, Marcin

> 2. OST flow building and running OST triggered
> _______________________________________________
> Devel mailing list – devel@ovirt.org
> To unsubscribe send an email to devel-leave@ovirt.org
> Privacy Statement: https://www.ovirt.org/privacy-policy.html
> oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
> List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/2FCJZLFJJ2SB3KVQ3YREZBVEYXPBQRUN/