Jenkins CI not triggering for ovirt-engine-dashboard gerrit patches

Description

Hi,

I submitted an ovirt-engine-dashboard patch [1] last night. The
gerrit-hooks ran just fine to attach the patch to its BZ [2]. However, the
normal Jenkins CI hooks/job did not. I tried rerunning the hooks with the
"Rerun-Hooks: all" gerrit comments on the patch, but Jenkins CI did not run
again. How can we tell if the Jenkins CI triggers on the
ovirt-engine-dashboard gerrit are still configured correctly? What can be
done to fix the problem?

To attempt to work around the issue, I tried the gerrit manual trigger page
[3]. Unfortunately my jenkins account (sdickers) does not have the
appropriate permission to the page. My teammate was able to manually
trigger the job and my patch cleared CI (thanks Greg). Who do I need to
ping to get that permission added to my account?

Regards,
Scott

[1] - https://gerrit.ovirt.org/66368
[2] - https://bugzilla.redhat.com/1389382
[3] - http://jenkins.ovirt.org/gerrit_manual_trigger/


Scott Dickerson
Senior Software Engineer
RHEV-M Engineering - UX Team
Red Hat, Inc

Activity

Show:

Oved Ourfali November 13, 2016 at 9:10 AM

Adding Eyal.

Thanks,
Oved

On Thu, Nov 10, 2016 at 9:27 PM, Scott Dickerson <sdickers@redhat.com>
wrote:

> Hi,
>
> I submitted an ovirt-engine-dashboard patch [1] last night. The
> gerrit-hooks ran just fine to attach the patch to its BZ [2]. However, the
> normal Jenkins CI hooks/job did not. I tried rerunning the hooks with the
> "Rerun-Hooks: all" gerrit comments on the patch, but Jenkins CI did not run
> again. How can we tell if the Jenkins CI triggers on the
> ovirt-engine-dashboard gerrit are still configured correctly? What can be
> done to fix the problem?
>
> To attempt to work around the issue, I tried the gerrit manual trigger
> page [3]. Unfortunately my jenkins account (sdickers) does not have the
> appropriate permission to the page. My teammate was able to manually
> trigger the job and my patch cleared CI (thanks Greg). Who do I need to
> ping to get that permission added to my account?
>
> Regards,
> Scott
>
> [1] - https://gerrit.ovirt.org/66368
> [2] - https://bugzilla.redhat.com/1389382
> [3] - http://jenkins.ovirt.org/gerrit_manual_trigger/
>
> –
> Scott Dickerson
> Senior Software Engineer
> RHEV-M Engineering - UX Team
> Red Hat, Inc
>

Scott Dickerson November 11, 2016 at 5:29 PM

I just pushed a new update on the patch. Jenkins CI started up the builds at the same time as the gerrit-hooks.

Hopefully you did something to make it start working. Otherwise, I'll give credit to the moon phase in relationship to solar flare activity. winking face

Greg Sheremeta November 10, 2016 at 8:35 PM

^ what he said.

"Manually triggered by user gshereme for Gerrit: https://gerrit.ovirt.org/66368"

Scott Dickerson November 10, 2016 at 8:35 PM

Those 2 were triggered manually by . On that patch at 11:39AM (or equivalent in your timezone), I triggered the hooks. You can see the BZ update task run, but not the typical Jenkins CI.

Patch 65925 [1], that submitted on Oct 31, shows the Jenkins CI tasks at the same time as the BZ updating one.

[1] - https://gerrit.ovirt.org/#/c/65925/

Eyal Edri November 10, 2016 at 8:12 PM

I see in the patch it just run the 2 jobs successfully:

Jenkins CI
8:23 PM

Patch Set 2: Continuous-Integration+1
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine-dashboard_master_check-patch-fc24-x86_64/74/ : SUCCESS
http://jenkins.ovirt.org/job/ovirt-engine-dashboard_master_check-patch-el7-x86_64/142/ : SUCCESS

Scott Dickerson November 10, 2016 at 8:04 PM

Eyal - Thanks for the add!

The repo does have the automation dir with both check-merged.sh and check-patch.sh. Everything worked last week with my last patch. Nothing has changed in the repo since then. I'll take a look at the docs, but I don't see any changes in the repo that would make it stop working now.

Other ideas?

Eyal Edri November 10, 2016 at 7:52 PM

Also, I've added you to the dev role on jenkins, so you can now trigger jobs using the manual trigger job

Eyal Edri November 10, 2016 at 7:50 PM

Hi Scott,

The hooks you see in Gerrit has nothing to do with Jenkins jobs, they are verifying correctness of patches and updating bugs.
In order to run jenkins jobs you need to make sure the project has an 'automation' dir and inside it 'check-patch.sh' and 'check-merged.sh' scripts.
You can look in other projects for examples, like ovirt-engine or vdsm.

more info can be found here: http://infra-docs.readthedocs.io/en/latest/CI/Build_and_test_standards.html

Fixed

Details

Assignee

Reporter

Priority

Created November 10, 2016 at 7:28 PM
Updated November 29, 2016 at 12:18 PM
Resolved November 12, 2016 at 9:14 AM

Flag notifications