Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Re: Rebase over other author's patch cannot be pushed to gerrit

Description

Forwarding to infra-support.

On 1 December 2016 at 18:03, Yaniv Bronheim <ybronhei@redhat.com> wrote:
> Not sure since when it was changed, but I noticed that I can't push patches
> if I'm not the author
>
> Counting objects: 50, done.
> Delta compression using up to 4 threads.
> Compressing objects: 100% (50/50), done.
> Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> Total 50 (delta 34), reused 0 (delta 0)
> remote: Resolving deltas: 100% (34/34)
> remote: Processing changes: refs: 1, done
> remote:
> remote: ERROR: In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> remote: ERROR: author email address rnachimu@redhat.com
> remote: ERROR: does not match your user account.
> remote: ERROR:
> remote: ERROR: The following addresses are currently registered:
> remote: ERROR: bronhaim@gmail.com
> remote: ERROR: ybronhei@redhat.com
> remote: ERROR:
> remote: ERROR: To register an email address, please visit:
> remote: ERROR: https://gerrit.ovirt.org/#/settings/contact
> remote:
> remote:
> To ssh://ybronhei@gerrit.ovirt.org:29418/vdsm
> ! [remote rejected] HEAD -> refs/for/master (invalid author)
> error: failed to push some refs to
> 'ssh://ybronhei@gerrit.ovirt.org:29418/vdsm'
>
> We must have permissions to do that, this is part of the rebasing part, and
> I think its fine to fix patches on behalf of someone else.. but its not the
> best practice for reviewing.
> anyway, please undo this change, unless its something that related only to
> my env.. let me know
>
> Thanks
>
> –
> Yaniv Bronhaim.
>
> _______________________________________________
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>

–
Barak Korren
bkorren@redhat.com
RHCE, RHCi, RHV-DevOps Team
https://ifireball.wordpress.com/

Activity

Show:

Former user December 25, 2016 at 4:57 PM

It was fixed by adding the following permissions as default:

Forge Author Identity ==> set to 'Registered Users' instead of 'Project Owners'
Forge Committer Identity ==> 'Registered Users' instead of 'Project Owners'

Eyal Edri December 8, 2016 at 12:55 PM

can you check if it works for you now?

Eyal Edri December 4, 2016 at 1:43 PM

can you check if rebasing on someone else patch and pushing again requires the 'forget identity' permission or its a different one?

Former user December 4, 2016 at 1:39 PM

you can always ignore the patchset and push your version again. otherwise
you cant rebase your patch on it I think

On Sun, Dec 4, 2016 at 3:00 PM, eyal edri [Administrator] (oVirt JIRA) <

–
Yaniv Bronhaim.

Eyal Edri December 4, 2016 at 12:59 PM

So what you're saying is any 'registered user' should have 'forge author
identity' permission?
Isn't that a bit of a security issue?

On Sun, Dec 4, 2016 at 2:58 PM, ybronhei (oVirt JIRA) <

–
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)

Former user December 4, 2016 at 12:57 PM

no.. this is not the issue here. I don't try to merge, I try to push a
change on a patch that im not the author of it. everyone should allow to do
so

On Sun, Dec 4, 2016 at 1:25 PM, eyal edri [Administrator] (oVirt JIRA) <

–
Yaniv Bronhaim.

Eyal Edri December 4, 2016 at 11:24 AM

OK, so as I suggested its best to verify the list of people in those groups and add/remove people who are missing.

Former user December 4, 2016 at 11:19 AM

Only the 'vdsm-master-maintainers' group have full permissions on the master branch (and 'vdsm-maintainers' group as the owner of the project)
The user has permission as a registered user: push, verify, code-review on the 'master' branch because he is not a member of that group.

Eyal Edri December 4, 2016 at 10:36 AM

If he has merge rights on master, then yes.
Maybe its a good idea to ask the vdsm maintainers who should have merge rights on master ( i.e belongs in the master maintainers group )

Fixed

Details

Assignee

Reporter

Priority

Parent

Created December 1, 2016 at 4:06 PM
Updated January 3, 2017 at 7:33 AM
Resolved December 25, 2016 at 4:57 PM