Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

add support for custom build params on build-on-demand jobs

Description

mburman reports that the nightly ovirt-engine build is missing the Chrome permutation.

From the build:

21:13:24 [INFO] Compiling 1 permutation 21:13:24 [INFO] Compiling permutation 0... 21:16:54 [INFO] Compile of permutations succeeded

That should compile 2 if we want Firefox and Chrome, or 3 if we also want IE.

mburman reports this started on November 30. I'm not sure what changed.

Adding build flags will fix:
DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=safari,gecko1_8"

Activity

Show:

Eyal Edri March 25, 2017 at 10:58 AM

For now we've enabled both FF and chrome permutations.
If anyone needs to run more permutations, he can send a patch to enable it on build-artifacts and run the build-on-demand from it.

Currently, we will not be adding custom params options to the build, due to reasons specified in the ticket.

Greg Sheremeta March 24, 2017 at 3:13 PM

I merged https://gerrit.ovirt.org/#/c/74462/ which simply runs both FF and Chrome permutations in build-artifacts.sh.

Can probably close this.

Barak Korren March 19, 2017 at 10:36 AM

The question is when do we want to build all permutations, what would be the conditions that cause this to be done.

Unfortunately, setting detailed specifications from Gerrit comments is not doable currently, because AFAIK the Jenkins Gerrit plugin does not make the comment text available to running jobs. We could, however, tell patch-set events apart from comment events, so we can theoretically make "build-artifacts.sh" behave differently if it was triggered manually as opposed to automatically (We will need to think how to expose this information to the script is a useful manner).

Eyal Edri March 19, 2017 at 8:18 AM

We need to find a solution for allowing builds with non default params to be triggered as part of build-on-demand, which we don't want to run all the time in CI.
This makes sense for many reasons, especially now that these jobs are used for OST manual testing, for e.g:

  • Build all permutations to verify a UI bug

  • Build with DEBUG mode on, to have more logs

So we need to find a generic way to support this in standard CI.

Greg Sheremeta March 17, 2017 at 6:44 PM

For the reporter of the issue, the goal is to have an entirely-built engine, all 3 GWT permutations [*]. I assume to save resources Question Mark, we stopped building the Chrome permutation. The builds now only do 1 permutation for Firefox.

Fixed

Details

Assignee

Reporter

Components

Priority

Parent

Created December 22, 2016 at 5:23 PM
Updated May 25, 2017 at 11:31 AM
Resolved March 25, 2017 at 10:58 AM

Flag notifications