Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Re: Gerrit don't check for "Signed-Off" anymore

Description

On Wed, Dec 28, 2016 at 11:42 AM, Tal Nisan <tnisan@redhat.com> wrote:

> Last night I've push a serious of patches and forgot to sign off, up until
> not long ago there was a hook that enforces that but it seems like it's not
> working anymore and I was able to push the patches without the sign off:
> https://gerrit.ovirt.org/#/c/69219/1
>
>
Its not a hook, its a definition per project, each project has the
defenition if to enforce signed-off commit:

'Require Signed-off-by in commit message:' - and its on TRUE now for
ovirt-engine, so I'm not sure how its possible that a patch got in, we'll
need to check gerrit logs to see.
Opening a ticket on it.

>
> _______________________________________________
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
>

–
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)

Activity

Show:

Tal Nisan January 3, 2017 at 9:22 AM

Tested yesterday and it seems to be working OK, can close

On Tue, Jan 3, 2017 at 9:56 AM, eyal edri [Administrator] (oVirt JIRA) <

Eyal Edri January 3, 2017 at 7:55 AM

any open issues still or we can close this?

Eyal Edri December 28, 2016 at 2:19 PM

the permission needed to rebase on other commits is 'forge author identity' and that is still valid for all registered uses.

Tal Nisan December 28, 2016 at 2:13 PM

Not ideal, it's used for rebasing other users patches, set it to
maintainers only please

On Wed, Dec 28, 2016 at 4:12 PM, Shlomo Ben David (oVirt JIRA) <

Former user December 28, 2016 at 2:02 PM
Edited

Projects in Gerrit can be configured to require a Signed-off-by in the footer of the commit message to enforce that every change is signed by the author, committer or uploader. If for a project a Signed-off-by is required and the commit message footer does not contain it, Gerrit rejects to push the commit with this error message.

This policy can be bypassed by having the access right 'Forge Committer'.

The 'Forge Committer' permissions were set to all Registered Users.
I set it only for 'Project Owners'.

Fixed

Details

Assignee

Reporter

Priority

Created December 28, 2016 at 10:13 AM
Updated January 30, 2017 at 9:25 AM
Resolved January 3, 2017 at 9:23 AM