Re-factor experimental groovy script

Description

The experimental Groovy scripts has several issues that should be resolved by re-factoring it:

  1. Turn the variables defined in the top of the file into constants with upper case manes to ensure they're not used in functions by mistake

  2. Remove unused arguments from functions

  3. Move the main() function definition to the top of the file so its easier to quickly see an overview of the whole flow

  4. Use the "global" constants inside main() instead of passing gazillion parameters to it.

  5. Pass parameters directly to function instead of turning them into strings and using interpolation

  6. Use 'for-each' loops instead of C-style indexed loops.

  7. Use consistent indention throughout the file

Activity

Show:

Barak Korren July 3, 2017 at 3:22 PM

Closing this ticket because the 'experimental' flow will be deprecated by the 'change-queue' flow.

Eyal Edri July 3, 2017 at 2:33 PM

is this in progress or done perhaps?

Won't Fix

Details

Assignee

Reporter

Components

Priority

Created January 22, 2017 at 9:57 AM
Updated August 3, 2017 at 3:02 PM
Resolved July 3, 2017 at 3:22 PM

Flag notifications