Won't Fix
Details
Assignee
infrainfraReporter
Barak KorrenBarak Korren(Deactivated)Components
Priority
Medium
Details
Details
Assignee
infra
infraReporter
Barak Korren
Barak Korren(Deactivated)Components
Priority
Created January 22, 2017 at 9:57 AM
Updated August 3, 2017 at 3:02 PM
Resolved July 3, 2017 at 3:22 PM
The experimental Groovy scripts has several issues that should be resolved by re-factoring it:
Turn the variables defined in the top of the file into constants with upper case manes to ensure they're not used in functions by mistake
Remove unused arguments from functions
Move the main() function definition to the top of the file so its easier to quickly see an overview of the whole flow
Use the "global" constants inside main() instead of passing gazillion parameters to it.
Pass parameters directly to function instead of turning them into strings and using interpolation
Use 'for-each' loops instead of C-style indexed loops.
Use consistent indention throughout the file