Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Make suit-type be the same string everywhere

Description

The 'suit-type' is parth of the OST suit name that determines which type of suit is it. For example: 'basic', 'upgrade', etc.

In various point it is important to know the suit-type to figure out where the testing suit will look for particular files. This is why the suit-type is often held in a separate variable.

To allow working with OST suits, it is desirable that the value of the 'suit-type' will be a consistent string everywhere. This is the case with the 'basic' suits, but this is not the case with suites like the (currently named) 'he_basic' suit.

For 'he_basic' (and other suites that have multi-worded names) the suit type is specified as 'he_basic' in YAML and in the names of the automation scripts, but as 'he-basic' in the name of the suit directory in the OST source repo.

In the CI system we typically regard underscore ('_') as a separator and hyphen ('-') as a joiner. So it is desirable to rename all the OST automation scripts and fix the YAML so that all OST suits will only have hyphens ('-') in their names.

Activity

Show:

Barak Korren January 24, 2017 at 12:16 PM

All patches merged.

Barak Korren January 23, 2017 at 9:03 PM

Patches verified. Now awaiting code review

Former user January 23, 2017 at 9:18 AM

Modified check patch to match this change https://gerrit.ovirt.org/#/c/70982/

Barak Korren January 22, 2017 at 4:39 PM

Change to implement fix in YAML:
https://gerrit.ovirt.org/#/c/70981/

Change to counterpart implement fix in OST:
https://gerrit.ovirt.org/#/c/70982/

Barak Korren January 22, 2017 at 4:21 PM

Since the suit type was already assumed to be the same string everywhere during the work on enabling transactional mirror use (https://ovirt-jira.atlassian.net/browse/OVIRT-575#icft=OVIRT-575), some jobs are currently failing:
http://jenkins.ovirt.org/job/ovirt_3.6_he-system-tests/820/console

Fixed

Details

Assignee

Reporter

Blocked By

Components

Priority

Parent

Created January 22, 2017 at 4:17 PM
Updated May 25, 2017 at 11:31 AM
Resolved January 24, 2017 at 12:16 PM

Flag notifications