Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Fwd: build-artifacts-on-demand marks CI +1

Description

Forwarding to Jira.

---------- Forwarded message ----------
From: Yedidyah Bar David <didi@redhat.com>
Date: 16 February 2017 at 15:02
Subject: build-artifacts-on-demand marks CI +1
To: infra <infra@ovirt.org>

Hi all,

I have a change [1] that currently fails some jenkins jobs, so it gets
-1 from it. After pushing patchset 4 (a mere rebase actually), I ran
build-artifacts-on-demand ("ci please build"), and it passed, and set
CI +1. Then I rebased again and again got -1 as expected.

IMO build-artifacts-on-demand should not set CI +1, it might be
misleading for the maintainer to think that all is good when in fact
CI failed.

[1] https://gerrit.ovirt.org/71590
–
Didi
_______________________________________________
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

–
Barak Korren
bkorren@redhat.com
RHCE, RHCi, RHV-DevOps Team
https://ifireball.wordpress.com/

Activity

Show:

Eyal Edri September 13, 2017 at 10:29 AM

fixed when we addressed the issue of Gerrit not reporting back.

Barak Korren July 12, 2017 at 3:58 PM

Looks like fixing this will require some non-trivial changes to the gerrit plugin configuration and code updates.

We need a separate environment to test this to not break everything, so blocking this ticket on OVIRT-1532.

Barak Korren July 5, 2017 at 5:31 PM

Patch did not work, need further research to find out how to implement this. It might require changes to the central Gerrit plugin configuration and to all jobs.

Barak Korren July 5, 2017 at 12:48 PM

can't tell because the build itself failed... although it does seem like it did not vote.

danken July 5, 2017 at 9:17 AM

let's see if a 'ci please build' votes on https://gerrit.ovirt.org/79021

Fixed

Details

Assignee

Reporter

Blocked By

Components

Priority

Parent

Created February 16, 2017 at 1:07 PM
Updated October 1, 2017 at 10:57 AM
Resolved September 13, 2017 at 10:29 AM

Flag notifications