spamming in github pull requests by ...not sure what it is.
Description
Activity
Michal Skrivanek April 4, 2017 at 1:02 PM
sorry for the noise, missed the last sentence
Michal Skrivanek April 4, 2017 at 1:01 PM
Spamming is still happening
see e.g. https://github.com/oVirt/ovirt-web-ui/pull/113
Former user March 13, 2017 at 7:00 PM
@Michal Skrivanek lago is not relevant here. lago-bot was configured in jenkins because lago was the first github project.
ovirt-web-ui has it's own tests in standard-CI https://github.com/oVirt/ovirt-web-ui/blob/master/automation/check-patch.sh . Only members of oVirt organization https://github.com/orgs/oVirt/people are allowed to run them because of security risks. For example attacker can submit whatever he wants and this code will be executed in DMZ with root permissions.
For external contributors project's maintainer can trigger CI using "ci please test" pattern without adding them to the organization.
I'm closing this ticket. We'll track spamming (multiple comments) in https://ovirt-jira.atlassian.net/browse/OVIRT-1250#icft=OVIRT-1250
Michal Skrivanek March 13, 2017 at 3:34 PM
I think that "member of organization" is still too vague and confusing. But better than before...
In addition, I'm not sure it's useful for this project, there are no tests in lago and we do not plan to have any
Former user March 13, 2017 at 3:30 PM
The message changed to "Commiter is not a member of organization nor whitelist. Please contact maintainer for patch verification."
@Eyal Edri @Michal Skrivanek Is it more clear?
maintainer can trigger check_patch by "ci test please" as usual or add author to the organization if needed
See https://github.com/oVirt/ovirt-web-ui/pull/98
There's a series of comments:
@lago-bot lago-bot commented 2 days ago
Can one of the admins verify this patch?
spamming is not useful
i'm not clear what is it actually trying to say