Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

limit the amount of warnings the whitelist bots sends to GitHub

Description

I'm not sure how the logic of the whitelist bot is done, but it looks like its sending too many messages back to GitHub:

https://github.com/oVirt/ovirt-ansible/pull/23 - on 1 commits there were 13 alerts.

Activity

Show:

Barak Korren September 17, 2017 at 8:47 AM

All code required to avoid spamming PRs had been merged as part of work on OVIRT-1522.

Barak Korren August 6, 2017 at 9:12 AM

We considered too possible solutions for this:

  1. Not use the built-in whitelist functionality of the PR-builder plugin, and use our existing whitelist file instead.

  2. Re-engineer things so that we will only have a single job that is configured with the PR-builder plugin.

Option #1 will probably not be popular with developers its also might not be even possible to implement this because it seems that Github does not expose the email addresses of contributors to Jenkins while out whilelist file is based on email addresses.

Option #2 essentially means implementing OVIRT-1522, so setting it as a blocker for this.

Barak Korren July 23, 2017 at 6:32 AM

There is no bot here.

This seems to be the logic on the GitHub pull-request trigger plugin when if is configured to filter by project/organisation membership.
I suspect the amount of alerts matches the amount of jobs we have triggering on pull request events exactly.

We probably need a staging environment for further testing and coming up with solutions, so adding https://ovirt-jira.atlassian.net/browse/OVIRT-1533#icft=OVIRT-1533 as a blocker

Fixed

Details

Assignee

Reporter

Blocked By

Priority

Parent

Created July 23, 2017 at 6:22 AM
Updated October 1, 2017 at 10:57 AM
Resolved September 17, 2017 at 8:47 AM

Flag notifications