GitHub STDCI jobs do not support post-merge functionality (Including build-artifacts and submitting to CQ)

Activity

Show:

Barak Korren October 18, 2017 at 12:20 PM

Functionality is now fully active in production.

Barak Korren September 24, 2017 at 2:54 PM

The patch linked to this ticket provides triggering of check-merged jobs on merged patches. Most users will probably also want build-artifacts to work as well as submitting build results to the change-queue. Therefore setting https://ovirt-jira.atlassian.net/browse/OVIRT-1486#icft=OVIRT-1486 as a blocker to this ticket.

Moving this ticket to 'BLOCKED' while the other ticket is being worked on and the patch is being reviewed.

Barak Korren September 17, 2017 at 8:50 AM

Renamed ticket to better indicate required work.

To solve this in the long-term we need post-merge jobs in GitHub.

Setting this as a blocker for https://ovirt-jira.atlassian.net/browse/OVIRT-1522#icft=OVIRT-1522 (Which in turn is a blocker for https://ovirt-jira.atlassian.net/browse/OVIRT-1548#icft=OVIRT-1548)

Eyal Edri August 24, 2017 at 9:22 AM

can you verify 'ci please build' does work on open PRs and we can close this ticket?

Barak Korren August 18, 2017 at 12:53 PM

It looks like you tried this on merged PRs... this will probably only work on unmerged PRs...

Martin Perina August 18, 2017 at 12:29 PM

We executed 'ci build please' on several commits through this week (for example [1]), but still the last RPM is from August 11th. So where is the error?

[1] https://github.com/oVirt/ovirt-ansible/pull/42
[2] http://plain.resources.ovirt.org/repos/ovirt/tested/master/rpm/el7/noarch/ovirt-ansible-roles-1.1.0-0.1.master.20170811091854.el7.centos.noarch.rpm

Ondra Machacek August 18, 2017 at 12:27 PM

Even 'ci build please' doesn't work.

Barak Korren August 18, 2017 at 12:02 PM

Current code only knows how to trigger on PR comments - to run the "check-merged" and "build-artifacts" jobs please type "ci build please".

(The hook configured in GitHub ATM is only for PR events BTW, a different hook will probably be needed for merge events)

New GitHub hooking code is in the works (https://ovirt-jira.atlassian.net/browse/OVIRT-1548#icft=OVIRT-1548) bull will take some time.

Martin Perina August 18, 2017 at 11:02 AM

Please fix asap, we cannot continue testing our patches without having updated RPM in master-snapshot repository

Fixed

Details

Assignee

Reporter

Components

Priority

Created August 18, 2017 at 10:38 AM
Updated November 1, 2017 at 10:02 AM
Resolved October 18, 2017 at 12:20 PM