Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

make Jenkins diff script a better script syntax wise

Description

None

Activity

Show:

Eyal Edri August 20, 2017 at 2:42 PM

It depends on how much time you think the refactoring will take and if the current code can be merged as is.
If its a matter of a few days to finish the review and merge it, then I agree there is no point in another ticket.
If the refactoring is major and will require more than a few days and longer code reviews, then it might make sense to have another ticket on it.

Former user August 20, 2017 at 1:59 PM

Eyal Edri August 20, 2017 at 1:40 PM

Not sure which other ticket you are referring to, can you add a link?

Former user August 20, 2017 at 1:36 PM

I'm not planning to create a new patch just for this ticket so it might be a good idea to just close this one and add the content of this one to the other ticket.
WDYT?

Eyal Edri August 20, 2017 at 12:43 PM

Can you elaborate what exactly it means 'syntax wise'? also, what is the current impact of the current script design?

Fixed

Details

Assignee

Reporter

Priority

Created August 20, 2017 at 12:28 PM
Updated August 31, 2017 at 1:02 PM
Resolved August 29, 2017 at 11:31 AM

Flag notifications