Fixed
Details
Assignee
Barak KorrenBarak Korren(Deactivated)Reporter
Barak KorrenBarak Korren(Deactivated)Blocked By
Code reviewPriority
Medium
Details
Details
Assignee
Barak Korren
Barak Korren(Deactivated)Reporter
Barak Korren
Barak Korren(Deactivated)Blocked By
Code review
Priority
Created November 7, 2017 at 9:24 AM
Updated January 31, 2018 at 3:33 PM
Resolved December 28, 2017 at 1:16 PM
The upstream source collection code is currently built included in two different files - "
upstream-source-collector.py
" and "poll-upstream-sources.py
". The files reside in "jobs/confs/python-scripts
" which in turn mean they are mean for embedding into jobs by JJB.This situation causes several issues:
It is not easy for users to use these scripts locally, and hence its difficult to build or test repos that include upstream source dependencies locally
There is code duplication between the two python scripts
Adding certain features is harder because it requires one of the scripts to have access to code that resides in the other script (See https://ovirt-jira.atlassian.net/browse/OVIRT-1641#icft=OVIRT-1641 for example)
It is impossible to use the code from pipelines (See OVIRT-1745)
It is not east to add tests for the code
It is desirable to have the upstream source handling code be concentrated into a single tool that resides in the '
scripts
' directory.