Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Removing build jobs makes change-queue fail with an exception

Description

When changes are added to the change queue, it records the build jobs that build artifacts for changed code.

If the build jobs are removed between the time the change is added to the queue and the time a tested jobs including that change is started, the code checking for completion of the build jobs would fail with an exception looking like the following:

'Script1' in this stack trace refers to our 'change-queue-tester.groovy' script. Relevant code section is the following:

The issue it with not checking for 'null' return from the 'Jenkins.instance.getItem(it.job_name)' funcntion call.

We should probably check for 'null' there and just ignore it. Similar check will probably be needed in other places in the code like for example when composing the 'extra-sources' file from the build job URLs.

Activity

Show:

Barak Korren February 5, 2018 at 8:19 AM

Fix patch merged

Barak Korren January 15, 2018 at 6:31 AM

updated the patch to try and completely remove build records for removed jobs, that should fix some of the failures of the kind you saw.

Unfortunately even with that fix its still possible to break the system if a job is removed between the time extra-source is generated to the time repoman runs.

Barak Korren January 14, 2018 at 5:57 PM

hmm... I wonder if we could make repoman just ignore that, doing that from the CQ code would be rather difficult at this point.

Gal Ben Haim January 14, 2018 at 5:18 PM
Edited

OST is invoked with "extra-sources' that doesn't exist:

Former user January 14, 2018 at 7:24 AM

We had the same issue I think ~1 month ago when someone removed old jobs.

Fixed

Details

Assignee

Reporter

Blocked By

Components

Priority

Parent

Created January 14, 2018 at 6:46 AM
Updated February 28, 2018 at 3:33 PM
Resolved February 5, 2018 at 8:19 AM