gerrit hooks aren't working after gerrit.ovirt.org upgrade
It seems like gerrit hooks aren't working now.
Patches that solve bugs with Bug-URL that submitted aren't causing the bug
to move to POST state.
For example - https://gerrit.ovirt.org/#/c/ovirt-engine/+/112416/
Can you please have a look?
Ugly hack is applied on gerrit.ovirt.org (basically setting draft=False always). I tried to re-run hooks on https://gerrit.ovirt.org/c/ovirt-engine/+/112145 and both “Set POST” and “Update Tracker” are now being run. This should provide some relive while I am working on changing the drafts handling.
This is related to gerrit changes. The old data structures are no longer valid since there is no longer a draft concept in gerrit. The code will have to be changed to accommodate that. I am going to apply a quick patch on production gerrit. Just make it threat all change as non-draft for now, not ideal, but at least it should start working for most of the patches.
While carefully studying the logs the following has been found that all hooks are enabled, detected and executed for ovirt-engine, but the ones in question give the following stack traces (for example for creation of https://gerrit.ovirt.org/c/ovirt-engine/+/112854 change):
Traceback (most recent call last):
File "/home/gerrit2/review_site/git/ovirt-engine.git/hooks/patchset-created.bz.98.set_post", line 409, in <module>
File "/home/gerrit2/review_site/git/ovirt-engine.git/hooks/patchset-created.bz.98.set_post", line 399, in main
AttributeError: 'NoneType' object has no attribute 'capitalize'
the execution then stops.
Thanks for clarification. Comparing to other projects, e.g. “vdsm” I see for “vdsm”  the following hooks are triggered:
Set POST::IGNORE, no bug url/s found
Update Tracker::IGNORE, no bug url/s found
that does not happen for ovirt-engine during patch set creation for some reason.