Gerrit hook adds unrelated patches to bugs

Description

Gerrit hook is wrongly looking for https://bugzilla.redhat.com/ URLs
in the commit message, and adding the patch to the bug.

Example patch:
https://gerrit.ovirt.org/c/vdsm/+/115339

I had to clean up the bug after the broken hook (see screenshot).

The hook should really look only in the single URL in (one or more)
Bug-Url headers:

Bug-Url: https://bugzilla.redhat.com/

I reported this years ago (I think for Related-To:), and I remember we had
a patch fixing this issue, but for some reason it was lost.

Nir

Attachments

1

Activity

Show:

Yedidyah Bar David June 22, 2021 at 1:42 PM

On Mon, Jun 21, 2021 at 9:58 PM Eyal Shenitzky <eshenitz@redhat.com> wrote:
>
>
> +Dusan Fodor
>
> On Mon, 21 Jun 2021 at 13:32, Nir Soffer <nsoffer@redhat.com> wrote:
>>
>> Gerrit hook is wrongly looking for https://bugzilla.redhat.com/ URLs
>> in the commit message, and adding the patch to the bug.
>>
>> Example patch:
>> https://gerrit.ovirt.org/c/vdsm/+/115339
>>
>> I had to clean up the bug after the broken hook (see screenshot).
>>
>> The hook should really look only in the single URL in (one or more)
>> Bug-Url headers:
>>
>> Bug-Url: https://bugzilla.redhat.com/
>>
>> I reported this years ago (I think for Related-To:), and I remember we had
>> a patch fixing this issue, but for some reason it was lost.
>>
>> Nir

See also: https://ovirt-jira.atlassian.net/browse/OVIRT-3075

Best regards,

Didi

Former user June 21, 2021 at 10:49 AM

+Dusan Fodor <dfodor@redhat.com>

On Mon, 21 Jun 2021 at 13:32, Nir Soffer <nsoffer@redhat.com> wrote:

> Gerrit hook is wrongly looking for https://bugzilla.redhat.com/ URLs
> in the commit message, and adding the patch to the bug.
>
> Example patch:
> https://gerrit.ovirt.org/c/vdsm/+/115339
>
> I had to clean up the bug after the broken hook (see screenshot).
>
> The hook should really look only in the single URL in (one or more)
> Bug-Url headers:
>
> Bug-Url: https://bugzilla.redhat.com/
>
> I reported this years ago (I think for Related-To:), and I remember we had
> a patch fixing this issue, but for some reason it was lost.
>
> Nir
>


Regards,
Eyal Shenitzky

Details

Assignee

Reporter

Priority

Created June 21, 2021 at 10:33 AM
Updated June 22, 2021 at 1:42 PM