update GitHub Pull Request Builder Plugin

Description

The current GitHub Pull Request Builder Plugin (v1.31.1) is not playing well with SECURITY-170 that we have applied in the latest Jenkins build:
https://github.com/janinko/ghprb/issues/408
https://issues.jenkins-ci.org/browse/JENKINS-34762

This causes some builds relying on GitHub to fail:
http://jenkins.ovirt.org/job/lago_master_check-merged-trigger/124/console

We need to confirm which version fixes that (as the bug is still open) and update

Activity

Show:
Evgheni Dereveanchin
August 10, 2016, 3:20 PM

The security bulletin reports this is fixed in 1.32.3 and above:
https://wiki.jenkins-ci.org/display/JENKINS/Plugins+affected+by+fix+for+SECURITY-170

Latest version is 1.33.1:
https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin

Its dependencies:
build-flow-plugin (version:0.12, optional)
token-macro (version:1.10, optional)
github-api (version:1.72.1)
git (version:2.2.4)
github (version:1.9.1)
matrix-project (version:1.6)
credentials (version:1.21)
plain-credentials (version:1.1)
ssh-agent (version:1.3)
job-dsl (version:1.39, optional)

our versions:
token-macro version:1.12.1
github-api version:1.72.1
git version:2.4.1
github version:1.17.1
matrix-project version:1.4.1
credentials version:1.26
plain-credentials version:1.1
ssh-agent version:1.9

So we should update this plugin and matrix-project

Evgheni Dereveanchin
August 15, 2016, 1:33 PM

Update tested on jenkins-staging.
Patch submitted for review and live jenkins update is scheduled for today:
https://gerrit.ovirt.org/62337

Evgheni Dereveanchin
August 15, 2016, 5:49 PM

plugin updated successfully. , could you please test if everything works as expected?

So far I'm seeing messages like these in the log:

Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #294 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #293 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #291 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #287 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #279 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #278 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #276 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #275 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #262 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #228 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #211 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.
Aug 15, 2016 5:48:05 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #74 was updated on repo lago-project/lago but there aren't any new comments nor commits; that may mean that commit status was updated.

Maybe we'll have to re-trigger failed builds to clear this.

Eyal Edri
August 18, 2016, 4:56 PM

Lago tests are now working again with the github plugin.

Fixed

Assignee

Evgheni Dereveanchin

Reporter

Evgheni Dereveanchin

Blocked By

None

Components

Priority

Medium
Configure