Issues

Select view

Select search mode

 
28 of 28

repoman CI Fails (as of 96127 change)

Fixed

Description

repoman CI fails again for patch [1]. This is most likely due to pip packages / distros changes. Since repoman is not changed that often we usually collect multiple issues there. We need to fix it to the point of repoman CI working again, so we can proceed with merging new changes.

[1] https://gerrit.ovirt.org/#/c/96127/

Details

Assignee

Reporter

Components

Priority

Created December 19, 2018 at 11:42 AM
Updated August 29, 2019 at 2:12 PM
Resolved December 19, 2018 at 4:07 PM

Activity

Show:

Anton MarchukovDecember 19, 2018 at 11:45 AM
Edited

We do in SDTCI: "pip install --upgrade pip" and "pip install --upgrade tox" that brings tox 3.6.0 and pip 18.1 as of now.

But the tox 3.6.0 version fails with:

bash-4.2$ tox
Traceback (most recent call last):
File "/usr/bin/tox", line 11, in <module>
sys.exit(cmdline())
File "/usr/lib/python2.7/site-packages/tox/session.py", line 42, in cmdline
main(args)
File "/usr/lib/python2.7/site-packages/tox/session.py", line 47, in main
config = prepare(args)
File "/usr/lib/python2.7/site-packages/tox/session.py", line 29, in prepare
config = parseconfig(args)
File "/usr/lib/python2.7/site-packages/tox/config.py", line 231, in parseconfig
ParseIni(config, config_file, content)
File "/usr/lib/python2.7/site-packages/tox/config.py", line 1056, in _init_
config.envconfigs[name] = self.make_envconfig(name, section, reader._subs, config)
File "/usr/lib/python2.7/site-packages/tox/config.py", line 1124, in make_envconfig
res = env_attr.postprocess(testenv_config=tc, value=res)
File "/usr/lib/python2.7/site-packages/tox/config.py", line 558, in basepython_default
implied_version = tox.PYTHON.PY_FACTORS_RE.match(factor).group(2)
AttributeError: 'NoneType' object has no attribute 'group'

This is an open bug in tox [1], but per maintainer comment:

Will try to fix this, however note in general we don't recommend to name environments as py- unless it signals that python basepython is to be used. You can use the underscore instead of the dash if you still want to name your environments with a py section.

So I renamed our "py" tox environment to "syspy" and this fixes this particular issue.

[1] https://github.com/tox-dev/tox/issues/1020

Flag notifications