Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Enable devs to specifiy patch dependencies for OST

Description

We have an issue with our system ATM where if there are patches for different projects that depend on one another, the system is unaware of that dependency.

What typically happens in this scenario is that sending the dependent patch makes the experimental test fail and keep failing until the other patch is also merged.

The change queue will handle this better, but the typical behaviour for it would be to reject both patches, unless they are somehow coordinated to make it into the same test.

The change queue core code already includes the ability to track and understand dependencies between changes. What is missing is the ability for developers to specify theses dependencies.

We would probably want to adopt OpenStack's convention here.

Activity

Show:

Barak Korren September 24, 2019 at 9:19 AM

well, we're probably not going to implement this, but as long as we use CQ - we can still get issues where dependent patches get tested alone

Eyal Edri September 23, 2019 at 11:28 AM

can we close this since patch dependencies will be included as part of the Zuul deployment?

Barak Korren June 18, 2017 at 3:39 PM

Created a patch to fix a code issue that would have prevented us from properly implementing dependencies for merged Gerrit changes.

Barak Korren June 18, 2017 at 3:06 PM

Here are some docs about how this is done in OpenStack:
https://docs.openstack.org/infra/manual/developers.html#cross-repository-dependencies

The basic Idea is that developers add a 'Depends-On:' header to the commit message follows by a 40-char Gerrit change ID.

One implication of this is that the same change ID can point to multiple changes (same change in different branches), so we will need to query Gerrit and find all actual changes with that ID.

Details

Assignee

Reporter

Components

Priority

Parent

Created June 15, 2017 at 2:53 PM
Updated September 24, 2019 at 9:19 AM